teras / Jubler

Jubler Subtitle Εditor
http://www.jubler.org/
GNU General Public License v2.0
145 stars 17 forks source link

Undetected markup in MicroDVD subtitles #25

Open myxal opened 3 years ago

myxal commented 3 years ago

Hello, I'm not very familiar with the inner workings of various subtitle formats, but have come across a few .sub files that have a text formatting markup in this style:

{483}{531}{y:i}* But we made it through *

(The asterisks are part of the displayed line, according to how mpv is treating this) Jubler doesn't recognise the markup and considers it part of the line to be displayed. Saving the subtitle into srt (my primary use case, as MKV-merge doesn't support sub) in Jubler results in this:

6
00:00:20,145 --> 00:00:22,147
{y:i}* But we made it through *

mpv just ignores this and displays the line with default type. When converting with ffmpeg, the line is converted to this:

5
00:00:19,320 --> 00:00:21,240
<i>* But we made it through *</i>

This displays in italics, as it does with the original sub file.

wesskywalker commented 3 years ago

That file was improperly converted from drtic (dtc) to sub. See full request here: https://github.com/teras/Jubler/issues/26

teras commented 11 months ago

Indeed styles in MicroDVD are not supported. They could be supported though. Here the italics is obvious. What other styles are supported? Is this list good enough?