terascope / file-assets

Teraslice processors for working with data stored in files on disk, S3 or HDFS.
MIT License
1 stars 2 forks source link

[file-asset-apis] Add invalid bucket error handing #1064

Closed sotojn closed 2 months ago

sotojn commented 2 months ago

This PR makes the following changes:

File-assets-apis changes

Improvements/Enhancements

File-assets

No changes.

godber commented 2 months ago

A quick comment here after talking with Joseph, I've asked that he keep the 403 error raised like it is with an improvement in the messaging and then I think it's safe to return all other 4xx errors as false.

Then he should document his reference for the implementation of validateBucketName. I think validateBucketName should be exported and used in the user interface validation places. The other functions in s3-helper should just be passing responses from the services through and not introducing even MORE validation on their responses. He should also dig up other S3 compatible services bucket name references. Then we'll consider how to move forward from there.

Also doing some low level testing on ceph to see what it's responses are when given: