search

terascope / kafka-assets

teraslice asset for kafka operations
MIT License
1 stars 1 forks source link

Update node-rdkafka #777

Closed busma13 closed 7 months ago

busma13 commented 7 months ago

This PR makes the following changes:

godber commented 7 months ago

Doesn't this need bumping:

https://github.com/terascope/kafka-assets/blob/10939725a169e5f96b85a8311f2cbc22936ccecc/packages/terafoundation_kafka_connector/package.json#L4

godber commented 7 months ago

And after that is updated, don't we pin that version somewhere in the Teraslice image build?

busma13 commented 7 months ago

Yes, I should have bumped that too.

busma13 commented 7 months ago

And the version is pinned here: https://github.com/terascope/base-docker-image/blob/master/Dockerfile