Pass in the node version to getDevDockerImage - this fixes the undefined, but results in the node version being added to the tag twice.
Automatically add node suffix to all tags.
Create removeNodeSuffixFromTag function. This turns something like v0.91.0-nodev18.18.2 into v0.91.0.
Add checks for options.nodeSuffix and removes the tag if false.
I chose to add the node suffix by default to make the transition simple when we decide that having a tag without a node suffix will never be necessary. At that point we can update formatDailyTag() to take nodeVersion as a parameter and update its test.
with node suffix:
daily terascope/teraslice:daily-2024.01.12-fe31c87bf9f-nodev16.20.2
dev terascope/teraslice:dev-local-nodev18.18.2
latest terascope/teraslice:latest-nodev16.20.2
prerelease terascope/teraslice:v0.91.1-rc.0-nodev16.20.2
tag terascope/teraslice:v0.91.0-nodev18.18.2
without node suffix:
daily terascope/teraslice:daily-2024.01.12-fe31c87bf9f
dev terascope/teraslice:dev-local
latest terascope/teraslice:latest
prerelease terascope/teraslice:v0.91.1-rc.0
tag terascope/teraslice:v0.91.0
This PR makes the following changes:
getDevDockerImage- this fixes the undefined, but results in the node version being added to the tag twice.removeNodeSuffixFromTagfunction. This turns something likev0.91.0-nodev18.18.2intov0.91.0.options.nodeSuffixand removes the tag iffalse.I chose to add the node suffix by default to make the transition simple when we decide that having a tag without a node suffix will never be necessary. At that point we can update
formatDailyTag()to takenodeVersionas a parameter and update its test.