terascope / teraslice

Scalable data processing pipelines in JavaScript
https://terascope.github.io/teraslice/
Apache License 2.0
50 stars 13 forks source link

Add node 22.2.0 #3628

Closed sotojn closed 1 month ago

sotojn commented 2 months ago

New Changes

Ref to issue #3605

sotojn commented 1 month ago

Should this be a minor or a patch bump for teraslice? I'm thinking minor because I consider node 22 support as a new feature, but it overall does not contribute much to the api at all. So there is an argument for a patch.

godber commented 1 month ago

I would say bump the minor. Adding support for Node 22 is the primary goal of this PR, you've made a few small changes related to that. Since you're adding features rather than fixing bugs, you bump minor.

godber commented 1 month ago

I've cancelled the current workflow on this and will retry after the images being built here:

https://github.com/terascope/base-docker-image/actions/runs/9278045777

are completed.