terascope / teraslice

Scalable data processing pipelines in JavaScript
https://terascope.github.io/teraslice/
Apache License 2.0
50 stars 13 forks source link

Set default label 'name' at init, not when PromMetrics class is created. #3647

Closed busma13 closed 3 weeks ago

busma13 commented 4 weeks ago

The default label name was being set at PromMetrics class creation within terafoundation instead of being set at initialization. It previously was getting the value for name from context.name, but this doesn't always match with teraslice.name and would never be correct if used with spaces.

There is now a test in prom-metrics-spec.ts that checks the default labels for the correct values.