terascope / teraslice

Scalable data processing pipelines in JavaScript
https://terascope.github.io/teraslice/
Apache License 2.0
50 stars 13 forks source link

Add labels to docker image #3677

Closed busma13 closed 2 months ago

busma13 commented 3 months ago

This PR makes the following changes:

ref: #3257

godber commented 2 months ago

When this PR is ready for review, lets:

busma13 commented 2 months ago

I will hold off on bumping versions until after a review, as I don't want to trigger another CI run currently.

mkhpalm commented 2 months ago

I've reviewed the labels and they look good for opencontainers image-spec

godber commented 2 months ago

@busma13 do you have an image built from this branch? Can you run the following command on the IMAGE and paste the output here?

docker inspect IMAGE | jq '.[0].Config.Labels'
busma13 commented 2 months ago
➜  teraslice git:(add-labels-to-docker-image) docker inspect terascope/teraslice:latest-nodev18.19.1 | jq '.[0].Config.Labels'
{
  "org.opencontainers.image.created": "2024-07-10T20:51:55.958Z",
  "org.opencontainers.image.documentation": "https://terascope.github.io/teraslice/docs/overview",
  "org.opencontainers.image.licenses": "Apache-2.0",
  "org.opencontainers.image.revision": "someHashValue",
  "org.opencontainers.image.source": "https://github.com/terascope/teraslice",
  "org.opencontainers.image.title": "Teraslice",
  "org.opencontainers.image.url": "https://terascope.github.io/teraslice",
  "org.opencontainers.image.vendor": "Terascope",
  "org.opencontainers.image.version": "2.0.1"
}
godber commented 2 months ago

So "org.opencontainers.image.revision": "someHashValue", is due to this being a local test, right?

busma13 commented 2 months ago

So "org.opencontainers.image.revision": "someHashValue", is due to this being a local test, right?

Correct. I set a local env var - export GITHUB_SHA=someHashValue