[teraslice] Asset load dependency check

terascope / teraslice

Scalable data processing pipelines in JavaScript

https://terascope.github.io/teraslice/

Apache License 2.0

50 stars 13 forks source link

[teraslice] Asset load dependency check #3822

Closed busma13 closed 1 week ago

busma13 commented 1 week ago

This PR makes the following changes:

adds a check on asset upload to see if the asset is compatible with the teraslice version
creates a test asset with a high minimum teraslice version
test the test asset to ensure an error is thrown
fix a bug that leaves behind an s3 object in some situations if an asset fails to upload

ref: #3685

godber commented 1 week ago

We really shouldn't be adding large binary files to the repo, especially one this large. At this point, since you've pushed the branch it's already there. So leave it.

busma13 commented 1 week ago

I think the single property makes more sense. Any other compatibility check can have it's own top level property. This also gives me a chance to use a smaller asset.