Closed godber closed 5 years ago
Erik also asked about adding information about the execution controller to cluster state as well.
Rather than reporting NA
, it could report the worker's version (doing so would be ideal). I am not sure what's involved in that, probably a lot of fiddly messaging that may not be worth the effort. Unless it's stored in the deployment, oh, it probably is.
I think the reason why we used N/A
was not that it was difficult to get information but the "node" could potentially have many executions running on it, with different teraslice versions.
Ok, for now, I am going to do this:
node_version
and teraslice_version
to N/A
at the worker/node level since it doesn't really have meaning in the k8s case (there's not node manager, a single node can run workers with versions that differ)image
property that reports the docker image used, including tag, which in our case provides version and build information.I think this solution makes a decent compromise, maybe the /txt
output should show image
instead of node_version
and teraslice_version
in the k8s master case. We haven't introduced any differences at the /txt
api based on cluster type, but I'll see if doing so is convenient.
/txt/workers
will now read more usefully:
###### Workers ######
assignment job_id ex_id node_id pod_name image
---------- ------ ----- --------- --------------------------------- ------------------
master N/A N/A 10.0.2.15 teraslice-master-794bdf85f6-dl49k teraslice-k8sdev:1
In k8s mode, I think teraslice currently reports the master version as the
teraslice_version
for each worker node. It should probably reportN/A
. Perhaps each worker listed underactive
should report it's own stats.