search

tercen / log_cutoff_pg

Transforms data using a logarithmic function with an optional cut-off of values.
0 stars 3 forks source link

Obsolete methods #2

Closed rdewijn closed 3 years ago

rdewijn commented 3 years ago

This operator contains a lot of obsolete methods, makes it overly complicated.

Propose to make a simple operator that performs log transformation, with the default option to cut-off negative values at a pre-specified level (cut method), and fails with multiple values per cell.

The issue with multiple values per cell and the option to bypass log transformation play a role in the LFC app. probabaly better to handle these there separately?

ginberg commented 3 years ago

@fnaji what's your take on this?

ginberg commented 3 years ago

hi @rdewijn, the operator has been simplified: Quantile shift is removed, pgCheckInput dependency is removed and it fails with multiple values per cell. Can you have a look at it again?

rdewijn commented 3 years ago

@ginberg the shift_offset was a component of the quantile shift method. Remove as well. Cut-off and log-base remain as properties.

ginberg commented 3 years ago

@rdewijn ok, I understand about the shift_offset. Should I also remove the 'Treatment of negative values' property?

rdewijn commented 3 years ago

@ginberg Indeed, 'Treatment_ of negative values' property is not strictly necessary (none could be replaced by setting cut-off = 0), but may be good to keep anyway to make explicit that negative values are (by default) replaced.

ginberg commented 3 years ago

that sounds good, I have updated the code