search

terebentina / sco.js

Javascript extensions for twitter bootstrap
http://projects.5mins.me/sco.js
Apache License 2.0
454 stars 107 forks source link

Introduces granular setting to countdown #15

Open jperkelens opened 11 years ago

jperkelens commented 11 years ago

Hi! Nice job with these plugins. I've added a 'granular' option to the countdown, which stops the string calculation at hours if there is more than a day left, and will only run the code to update on the hour change.

This can obviously be extended for any level of granularity and I'm happy to do so if you feel its a good idea.

terebentina commented 11 years ago

This is a nice idea...how about instead of granularity: true/false you create a granularity: d/h/m/s?

jperkelens commented 11 years ago

Sounds good. I'll work on it in the next day or two and amend the pull request.

Cheers.

On Tue, Aug 20, 2013 at 11:07 AM, Dan Caragea notifications@github.comwrote:

This is a nice idea...how about instead of granularity: true/false you create a granularity: d/h/m/s?

— Reply to this email directly or view it on GitHubhttps://github.com/terebentina/sco.js/pull/15#issuecomment-22951751 .

jperkelens commented 11 years ago

Created the setting as you requested. Give it a spin, lemme know what you think.

jperkelens commented 11 years ago

Hi again, any chance you'll pull this in soon?

terebentina commented 11 years ago

Yup, tomorrow will do