search

terezka / elm-charts

Create SVG charts in Elm.
https://www.elm-charts.org
BSD 3-Clause "New" or "Revised" License
711 stars 67 forks source link

Fix SmoothLines example and use Point type for all examples; without duplicating definition of Point #37

Closed mathiasbaert closed 7 years ago

mathiasbaert commented 7 years ago

After I fixed this, I saw there was already a pull request by @matthiaskern

His pull request involves fewer changes and does not require clients to import Plot.Types exposing (Point). However, this leaves duplicated definitions of Point in src/Plot.elm end src/Plot/Types.elm

I'm not familiar enough with elm to judge which approach is preferable

terezka commented 7 years ago

Yeah, it's right to have it in Types.elm, but I had to send out a patch some something and I didn't it to be a major bump. It will be back to the right way in a sec ^_^

mathiasbaert commented 7 years ago

that makes sense