search

terezka / elm-charts

Create SVG charts in Elm.
https://www.elm-charts.org
BSD 3-Clause "New" or "Revised" License
711 stars 67 forks source link

Render customAttrs for Scatter. #42

Closed chancyk closed 7 years ago

chancyk commented 7 years ago

Scatter.customAttrs was being ignored by Scatter.view.

The behavior of simply appending the customAttrs was a bit surprising as Svg.Attributes.style does not behave like Html.Attributes.style; In Svg the last style will override the others instead of being accumulated into a list of styles. I've included customAttrs last so that its style takes precedence, which was a bit confusing when it overrode Scatter.fill and Scatter.stroke since those get converted to style.

terezka commented 7 years ago

Hey! Sorry I didn't answer earlier for this - It shouldn't be a problem in the new api!