terezka / elm-charts

Create SVG charts in Elm.
https://www.elm-charts.org
BSD 3-Clause "New" or "Revised" License
711 stars 67 forks source link

Why is there no junks in viewBarsCustom? #57

Closed anagrius closed 3 years ago

anagrius commented 7 years ago

Junks don't seem to be supported in viewBarsCustom. Any good reason for this?

terezka commented 7 years ago

Hi! You mean like they don't show up or you can't add them in the first place? It should use the same customizations as it does in viewSeriesCustom!

anagrius commented 7 years ago

Hi T,

Yes. But if you look at the view function for custom bars. It is not actually used in rendering. :)

On 9 May 2017, at 23:09, Tereza Sokol notifications@github.com wrote:

Hi! You mean like they don't show up or you can't add them in the first place? It should use the same customizations http://package.elm-lang.org/packages/terezka/elm-plot/5.0.1/Plot#PlotCustomizations as it does in viewSeriesCustom!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/terezka/elm-plot/issues/57#issuecomment-300302159, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJmGtE5FjCE-d69LlmD2xmUv2Cv00vUks5r4NXugaJpZM4NPlqB.

terezka commented 7 years ago

... I see. That's a little silly and will be remedied in the next version! Until then, sorry for the inconvenience!