search

terezka / line-charts

Archived in favor of terezka/elm-charts.
https://terezka.github.io/line-charts
BSD 3-Clause "New" or "Revised" License
456 stars 45 forks source link

HoverMany and Hover don't actually hover #59

Open Munksgaard opened 6 years ago

Munksgaard commented 6 years ago

Ellie link

I've tried to port the first example from the old version to 0.19, but the hoverMany function seems to work differently from what it did back then. I would expect hoverMany to create a little box next to the cursor or the actual point in question, but instead it seems like a box is added at the bottom of the chart. The same happens if I try to use hover

Am I missing something?

yuzisee commented 5 years ago

Apparently a typo (created during migration to 0.19?) introduced on Oct 27, 2018

https://github.com/terezka/line-charts/commit/a92d43dedb623823fe09d8cdfe26ce016b30d867#r31813341

Munksgaard commented 5 years ago

Certainly looks like it.

jartsap commented 5 years ago

Hi, is there any hope that this would be fixed in near future?

LiberalArtist commented 5 years ago

I believe this is fixed by #58, which was merged recently, but there isn't a new version on https://package.elm-lang.org yet.

QuinnFreedman commented 5 years ago

I can confirm that I am still getting this error in 2.0.0 (the current version on package.elm-lang.org) and it's causing me a lot of trouble.

Is there any chance of getting a new package version with this fix?

LiberalArtist commented 4 years ago

I've vendored this package in as a Git submodule to get the fix from #58, and I can report that it's working great for us.