terhechte / SourceKittenDaemon

Swift Auto Completions for any Text Editor
MIT License
529 stars 37 forks source link

Simplified Dependencies #58

Closed terhechte closed 6 years ago

terhechte commented 7 years ago

Hey,

In line with #55 I'd like to simplify our dependencies a bit. The current Packages stem mostly from the original implementation where the SPM landscape was less vibrant. Most importantly, I'd like to replace Vapor with something much more lightweight as we're currently importing a ton of unused stuff via Vapor. In addition to that, we also don't need the speed or flexibility that Vapor provides.

I wanted to find something which is lightweight (very little additional dependencies), works on macOS and Linux, is kinda well supported, and maybe offers async usage and a sane API.

I did some research, and thought about these three alternatives:

Opinions on this? @nathankot ?

Cheers!

terhechte commented 7 years ago

I've created a test branch that replaces Vapor with Embassy. If somebody wants to play around with it, it can be found here:

https://github.com/terhechte/SourceKittenDaemon/pull/61

nathankot commented 7 years ago

Hmmm does Vapor not work on Linux? TBH I'm leaning towards keeping Vapor or just de-prioritising this - not immediately seeing the gains here, and Vapor does seem like a stronger bet in terms of whether or not it will still be around in the future.

On the flipside if you find that Embassy works better I'm all for it!

felix91gr commented 6 years ago

Closed as per #61 :)