terijaki / vcmuellheim

This is the github repository for the Volleyballclub Müllheim e.V. website.

https://vcmuellheim.de

1 stars 0 forks source link

Refactor Team ID Change detection #133

Closed terijaki closed 3 months ago

terijaki commented 5 months ago

The process for detecting that a teams ID has changed (https://github.com/terijaki/vcmuellheim/blob/main/.github/workflows/teams_check.yml) is highly flawed and should be recreated from scratch.

Rather than removing sbvvIds from teams, the team component should only render the element if the ID is contained in the club.json
GH Issue creation does not require a third party workflow since Github CLI is preinstalled anyway and we can therefore use the command directly: https://docs.github.com/en/actions/using-workflows/using-github-cli-in-workflows / https://cli.github.com/manual/gh_issue_create

terijaki commented 3 months ago

example debug messages:

156 #158 #159