search

terikon / cordova-plugin-photo-library

Maintainer needed. Please contact if you're using this library in your project
MIT License
149 stars 295 forks source link

Please release a new version to fix rangeAt in swift4 #164

Open vitorbarros opened 5 years ago

vitorbarros commented 5 years ago

Hello.

I am getting the deprecation error for rangeAt function in swift 4. I see that in the master it was already fixed, please release a new version to fix it.

baltejsingh88 commented 5 years ago

+1 Facing the same problem

wennjie commented 5 years ago

(at:0)

vitorbarros commented 5 years ago

I think this plugin is dead! Anyone answer an issue

baltejsingh88 commented 5 years ago

@vitorbarros Maybe you try this out. https://github.com/terikon/cordova-plugin-photo-library/issues/163#issuecomment-485805403

cabaird commented 5 years ago

It looks like this has been fix has been made in master, but has not been published as a release. Can we get a release made?

gwenael-louandre commented 5 years ago

There are several points to correct for Swift 5. I tried on my project and that's ok. Is it possible to integrate them and publish a new version?

Here are the list of the replacements : Line 308 : (imageData: Data?, dataUTI: String?, orientation: UIImage.Orientation, info: [AnyHashable: Any]?) in

Line 450 : (imageData: Data?, dataUTI: String?, orientation: UIImage.Orientation, info: [AnyHashable: Any]?) in

Line 482 : (imageData: Data?, dataUTI: String?, orientation: UIImage.Orientation, info: [AnyHashable: Any]?) in

Line 587 : (imageData: Data?, dataUTI: String?, orientation: UIImageOrientation, info: [AnyHashable: Any]?) in

Line 761 : range: NSMakeRange(0, url.count)) else { // TODO: firstMatchInString seems to be slow for unknown

Line 823 : data = image.jpegData(compressionQuality: CGFloat(quality))

Line 826 : data = image.jpegData(compressionQuality: CGFloat(quality))

itemir commented 5 years ago

+1 to this

5heri commented 4 years ago

+1

stenionobresem commented 4 years ago

Anyone have solution for this issue?

cabaird commented 4 years ago

Is anyone still working on this project? Can we get a solution. Our workaround to install from the master branch just broke builds this morning as there was a commit to master in the forked repo that broke compatibility. This issue would have been much easier to find and fix if I were installing this at a released version, rather than directly from that repo.

muhammaddadu commented 4 years ago

👍

davidseek commented 4 years ago

this worked for me:

https://github.com/terikon/cordova-plugin-photo-library/issues/163#issuecomment-485805403

I manually deleted the existing plugins and reinstalled from his fork