search

terinjokes / docker-npmjs

Docker image for a private npmjs repository
154 stars 26 forks source link

Split into two images? #3

Closed terinjokes closed 10 years ago

terinjokes commented 11 years ago

Would people prefer that this live in two containers? For example, one for npmjs and one for npm-delegate? Or do people like the integrated approach I went with originally here?

Raynos commented 11 years ago

If this works out of the box as is, it is amazing.

Having tried setting up private npm a bunch of times before its painfully difficult to do.

Maybe support both if you think there is value in it?

terinjokes commented 11 years ago

It should work out of the box as is, we're using it internally here, it and seems a bunch of people elsewhere are as well. If it doesn't, that's an issue ;)

I think I might hold off deciding just a tad to see the direction that Docker (and community) is going with regard to networking

terinjokes commented 11 years ago

I think with the link functionality added in Docker 0.6.5, it looks clearer and clearer that npm-delegate should exist somewhere else.

jasisk commented 10 years ago

I think it's worth it, particularly in preparation for 0.8. This issue is scheduled for that release and is for spinning up multiple containers from a single dockerfile.

terinjokes commented 10 years ago

I've decided to wait to see what options well get as we progress to 1.0 On Dec 20, 2013 2:51 PM, "Jean-Charles Sisk" notifications@github.com wrote:

I think it's worth it, particularly in preparation for when 0.8 get's a little closer to reality. This PR https://github.com/dotcloud/docker/issues/1352 is scheduled for that release and is for spinning up multiple containers from a single dockerfile.

— Reply to this email directly or view it on GitHubhttps://github.com/terinjokes/docker-npmjs/issues/3#issuecomment-31036706 .