search

terinjokes / gulp-uglify

Minify files with UglifyJS
MIT License
1.23k stars 154 forks source link

fix(composer): Don't callback twice #329

Closed robpalme closed 6 years ago

robpalme commented 6 years ago

If connected streams downstream from gulp-uglifuy throw, gulp-uglify was calling back twice which masks the original error. This change ensures the callback is only ever called once. A test case is provided that fails on the old code and passes with the fixed code.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.8%) to 96.61% when pulling 4a549962ec91e81d82519e26ab092654a287505c on robpalme:bug/double-callback into 14f1d7190fc94efd6f29b2e16957418bbf1a3adf on terinjokes:master.

terinjokes commented 6 years ago

You have some lint failures. Also, please use testdouble doubles as inputs to composer.

robpalme commented 6 years ago

Fixed lint failures. Composer inputs now use testdouble doubles. Increased test coverage of composer.js to 100%.

terinjokes commented 6 years ago

Merged as 27b26d4f8f337386ac7cce6bc4e09effb066e1a4.