search

terinjokes / gulp-uglify

Minify files with UglifyJS
MIT License
1.23k stars 154 forks source link

Found a stupid behavior: unnecessary compilation and cause some error #345

Closed yesongling closed 5 years ago

yesongling commented 5 years ago

source image

compilation image

you know arguments object is not a real Javascript Array type, so use arguments[0] cannot get the first element of arguments object. but actually the gulp-uglify compress it from arguments['0'] to arguments[0]. that is the problem.

i can solve this problem by passing parameters instead, but i think it is still a compress issue

terinjokes commented 5 years ago

gulp-uglify does no compression itself, instead relying on UglifyJS directly.

You should attempt to reproduce with their CLI to, and report a bug to them.

On Sun, Nov 11, 2018, 7:58 PM Kevin Ye <notifications@github.com wrote:

source [image: image] https://user-images.githubusercontent.com/28178382/48325519-01c23d80-e671-11e8-9272-f855353ee2ad.png compilation [image: image] https://user-images.githubusercontent.com/28178382/48325536-13a3e080-e671-11e8-81bc-dd2b33c7a058.png

you know arguments object is not a real Javascript Array type, so use arguments[0] cannot get the first element of arguments object. but actually the gulp-uglify compress it from arguments['0'] to arguments[0]. that is the problem.

i can solve this problem by passing parameters instead, but i think it is still a compress issue

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/terinjokes/gulp-uglify/issues/345, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQsZQb3DnbYHTSI1-fBaK-xPHGVjn6aks5uuPHugaJpZM4YY6kq .

yesongling commented 5 years ago

OK, thanks