terinjokes / mixere

A modern fork of mixere, a Windows audio mixer for live productions.
GNU General Public License v2.0
12 stars 1 forks source link

Unicode Support #1

Closed terinjokes closed 2 years ago

terinjokes commented 2 years ago

Mixere still uses the system's local code page. This prevents uses from opening audio files with names that contain graphemes that cannot be represented in their code page (for example, files with CJK graphemes on an English copy of Windows).

terinjokes commented 2 years ago

After careful consideration this was fixed in Windows versions newer than 1903, by using Window's UTF-8 support. This allows Mixere to continue to use char internally, only now they represent UTF-8 (and can be surrogate pairs). This matches common operation on other platforms, and avoids having to do a large refactor (without tests) to wchar_t.

This was implemented in ef60daa7ae15ec71d527b2c945dc80ab9a23bf53.

terinjokes commented 2 years ago

Looks like a fix for Wine will be included in a future release, as a fix landed in https://github.com/wine-mirror/wine/commit/967ef0bf41fc6742398313ebdebd681c1b33dbc3.