search

teris / rapidjson

Automatically exported from code.google.com/p/rapidjson
MIT License
0 stars 0 forks source link

Comma not allowed after last field of C++98 enum #49

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. compile with gcc (eg 4.4.3) with -pedantic

What version of the product are you using? On what operating system?
0.11

Please provide any additional information below.

In rapidjson.h, there is one comma after the final field in the enum 'Type'. 
This is not allowed in C++98:

http://code.google.com/p/rapidjson/source/browse/trunk/include/rapidjson/rapidjs
on.h?r=131#251

Solution:
    kNumberType = 6,    //!< number
should be changed to
    kNumberType = 6     //!< number

Original issue reported on code.google.com by lundb...@gmail.com on 7 Dec 2012 at 9:47

GoogleCodeExporter commented 8 years ago 
I have pushed a fix for this issue to my GitHub fork at
https://github.com/pah/rapidjson/commit/69f40dc80

Original comment by philipp....@gmail.com on 1 Feb 2014 at 6:55

GoogleCodeExporter commented 8 years ago 
https://github.com/miloyip/rapidjson/commit/1ffd7b4a7d6c7064e6637e379c522cf4cdb1
d2f1

Original comment by milo...@gmail.com on 25 Jun 2014 at 4:11