gap between POI and icon

teritorio / vido

POI WebMap application

https://www.teritorio.fr/solution/webapplication-api/

GNU Affero General Public License v3.0

1 stars 0 forks source link

gap between POI and icon #183

Closed vinber closed 6 months ago

vinber commented 8 months ago

https://city-demo-bordeaux.beta.appcarto.teritorio.xyz/5172/#map=20/44.8314951/-0.5980143

sbterito commented 8 months ago

Else where https://carte.lecoeurdeslandes.com/648/#map=17.79/43.934129/-0.924561

frodrigo commented 8 months ago

It is the same for all.

wazolab commented 6 months ago

Does this bug is still here ?? I can't reproduce it on my side ... I tried to zoom-in/zoom-out but it's seems to keep the right position.

frodrigo commented 6 months ago

Hum. In fact I was thinking about an other issue

sbterito commented 6 months ago

Still there : https://carte.lecoeurdeslandes.com/648/#map=17.79/43.934129/-0.924561 no ?

frodrigo commented 6 months ago

Still there : https://carte.lecoeurdeslandes.com/648/#map=17.79/43.934129/-0.924561 no ? !

No. This one is an other issue. It is a polygon is OSM and the WP API is not so good on making a pont from it.

wazolab commented 6 months ago

Hum. In fact I was thinking about an other issue

So the real issue of this ticket is about the Pin marker being shifted from the POI marker right ?

frodrigo commented 6 months ago

So the real issue of this ticket is about the Pin marker being shifted from the POI marker right ?

No that an other issue. The existing (broken) code is to fix the shifted pin. Not the shifted icon.

wazolab commented 6 months ago

After looking, in my opinion, we have an issue on the POI icon not on Red Marker (which is on the right position). Red Marker or not, the POI icon is shifted sometimes. In fact it's shifted when we are zoomed-out (when we can see several POIs) and then zoom-in ... at some point during the zooming we are assigning wrongly the coordinates to the Marker.

POI icon shifter with Red Marker (at the right place) Screenshot from 2024-05-02 12-36-15

Everything ok here Screenshot from 2024-05-02 12-36-56

POI icon shifted without Red Marker (if we click on POI Icon, Red Marker will be placed like in the first case, which is ok) Screenshot from 2024-05-02 12-37-32

wazolab commented 6 months ago

@frodrigo I think i've fixed it with this commit.

But I am not very satisfied because it removes a Marker to add a new one in case coordinates from feature differs from the marker coordinates.

The real issue here, is because feature.geometry.coordinates is somehow updated (it looks like rouding precisison difference) and the marker not. In my opinion the feature geometry shouldn't be changed right ?