terjeio / ioSender

A GCode Sender for Grbl and grblHAL written in C# (Windows only).
BSD 3-Clause "New" or "Revised" License
222 stars 66 forks source link

TLO probing inaccurate offset #262

Closed calabr closed 1 year ago

calabr commented 1 year ago

sender 2.0.41p8 In TLO probing circle offset aplyed with G10L20P1Z0 which use current position instead of probbing result. I's give some speed and acceleration depended error relaive to actual probbing results. In my case I get 0.02 - 0.04 mm difference to edge-finder Z mesurement results with reasonable slow feed rate. I also found, G10L20P1Z0 applyed twice ( shown in terminal window) @terjeio could you please set the same algoithm as for egde finder

terjeio commented 1 year ago

Is this in from the Center finder tab or the Tool length offset tab?

FYI I am on holiday and do not have access to a machine to test with so I cannot look into this before I am back home.

calabr commented 1 year ago

Hello @terjeio Wish you happy New Year! It's from TLO tab. Edge finder and center finder works correctly.

terjeio commented 1 year ago

Happy new year!

You are correct in that the current position is incorrectly used instead of the probed position. I'll fix this and retest when I am back home.

I also found, G10L20P1Z0 applyed twice ( shown in terminal window)

I cannot immediately see this happening from looking at the code, so this has also to wait until I am back.

terjeio commented 1 year ago

I have now uploaded a new edge version with a fix.

calabr commented 1 year ago

Verifyed with 2.0.43p3