Lock globalyzer to working version

terkelg / tiny-glob

Super tiny and ~350% faster alternative to node-glob

MIT License

856 stars 25 forks source link

Lock globalyzer to working version #56

Closed benmccann closed 3 years ago

benmccann commented 3 years ago

There are currently four failing tests. This fixes two of them. A new version of globalyzer was released and without this lock file it picks up the latest causing the tests to fail. The other two test failures were introduced by a recent commit https://github.com/terkelg/tiny-glob/pull/44#issuecomment-730611095 and are being fixed in https://github.com/terkelg/tiny-glob/pull/59

lukeed commented 3 years ago

This wouldn't fix anything. It SHOULD be failing, since users would also be picking up latest globalyzer on install.

This is why lockfiles are/can be misleading

benmccann commented 3 years ago

Ah, right. Thanks for catching that @lukeed. I've updated this to also update the package.json, which should actually fix the issue. I think the package-lock.json is still helpful so I left it, but I'm happy to drop it from this change if you prefer