search

terl / lazysodium-android

An Android implementation of the Libsodium cryptography library. For the lazy dev.
https://github.com/terl/lazysodium-java/wiki
Mozilla Public License 2.0
108 stars 25 forks source link

Fix Maven repository in README #42

Closed kdrag0n closed 3 years ago

kdrag0n commented 3 years ago

Only lazysodium-java is in JCenter; lazysodium-android is in its own Bintray repository. This confused me for a while when I was trying to add it as a dependency.

gurpreet- commented 3 years ago

Hey thanks for the contribution. Whoops it shouldn't be jcenter(). Though I don't think it should be this as well:

maven { url 'https://dl.bintray.com/terl/lazysodium-maven' }

I think it should be mavenCentral() as that's accepted by a lot of organisations rather than them having to set lazysodium's own separate maven repo in their gradle files.

kdrag0n commented 3 years ago

I was not able to get the package from Maven Central:

Failed to resolve: com.goterl.lazycode:lazysodium-android:4.3.2

A search on Maven Central's Sonatype instance confirms this: https://search.maven.org/search?q=lazysodium

Is there something I'm missing here?

gurpreet- commented 3 years ago

Work is on-going to get this into mavenCentral https://github.com/terl/lazysodium-java/pull/100. I'll revisit this later.

gurpreet- commented 3 years ago

Hey I updated the README to read mavenCentral instead because this library is now on mavenCentral.

Closing this. Thanks for your PR though 👍

kdrag0n commented 3 years ago

Thanks for the update, that's definitely the better solution now that JCenter is being deprecated.