search

terl / lazysodium-java

A Java implementation of the Libsodium crypto library. For the lazy dev.
https://github.com/terl/lazysodium-java/wiki
Mozilla Public License 2.0
135 stars 47 forks source link

Missing resource-loader dependency #55

Closed MakarovS closed 4 years ago

MakarovS commented 5 years ago

Hi! In 4.1.0 release you added a dependency to com.github.libly:resource-loader:1.3.3, but it is not published on Maven Central. I see that you are a contributor of that library as well - could you please publish it?

gurpreet- commented 5 years ago

Hi @MakarovS,

Sure. I wanted to move away from Jitpack as it does not have the precision that Bintray has. So I have uploaded it to Bintray https://bintray.com/libly/maven/resource-loader and I have submitted it for reviewal for going into Maven Central. So it should be in there very shortly.

mabrcosta commented 4 years ago

Hi @gurpreet-,

Can you update the documentation to include this dependency and where to get it? I could only get the latest version (4.1.0) working because you vaguely mention Jitpack in the previous comment and tried to check if the required version was somehow still available there.

It should also be noted that with the namespace change from com.github.libly to libly.co it rendered the latest released version of lazysodium-java unable to use Bintray repo.

gurpreet- commented 4 years ago

So the problem was that I did not add version 1.3.3 of resource-loader to jCenter which is what version 4.1.0 depended on! How silly.

I have fixed it in the latest version 4.2.0 by adding version 1.3.4 of resource-loader to jCenter. You can use Bintray or jCenter to get lazysodium. Bintray always has the latest version faster than jCenter.

gurpreet- commented 4 years ago

So this means you need to include jCenter in you repositories section too. Something like the following should suffice:

// Top level build file 
repositories {
    jcenter()

    // May not need this too as lazysodium is available in jCenter too
    // but jCenter often is slower to update.
    maven {
        url  "https://dl.bintray.com/terl/lazysodium-maven"
    }
}

// Add to dependencies section in app level build file
dependencies {
    implementation "com.goterl.lazycode:lazysodium-java:VERSION_NUMBER"
}
MakarovS commented 4 years ago

@gurpreet- Thanks!

gurpreet- commented 4 years ago

Okay so this one has been solved. Just issue #56 that remains outstanding.