Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()"

terl / lazysodium-java

A Java implementation of the Libsodium crypto library. For the lazy dev.

https://github.com/terl/lazysodium-java/wiki

Mozilla Public License 2.0

135 stars 48 forks source link

Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()" #75

Closed jcihocki closed 4 years ago

jcihocki commented 4 years ago

Created a PR here, if you're interested: https://github.com/jcihocki/lazysodium-java/pull/

native method declared in Sodium.java has subKeyId as long, native method expects unsigned char * for both salt and personal so it should be byte[]

gurpreet- commented 4 years ago

Hey nice spot, I have updated this and will be available in the next release!

jcihocki commented 4 years ago

Awesome, thank you!

nathankurtyka commented 4 years ago

@gurpreet- Hello! Any approximate timeline for the next release?

I only ask because we're considering migrating our production stack to LazySodium, and this issue might be a blocker.

gurpreet- commented 4 years ago

@nathankurtyka Will release a new version today! It contains a minor breaking change in order to fix some scrypt related methods.

gurpreet- commented 4 years ago

Fixed in release 4.3.0.

gurpreet- commented 4 years ago

I've migrated my CI infrastructure to AzureCI (#77) so now we also have the benefit of testing across platforms rather than just testing on Linux. Should be extra resilient to these failures.

Will update Lazysodium Android ASAP too.