xenapi_image_service flag is redundant with image_service flag

[termie]

nova/virt/xenapi/vm_utils.py uses FLAGS.xenapi_image_service (values = glance or objectstore) to switch between Glance and Objectstore. It should probably use image_service instead (values = nova.image.glance.GlanceImageService or nova.image.s3.S3ImageService).

It will probably fail if one is out of sync with the other.

---

Imported from Launchpad using lp2gh.

• date created: 2011-01-27T16:46:43Z
• owner: ttx
• the launchpad url was https://bugs.launchpad.net/bugs/708754

[termie]

(by ewanmellor) As per a recent thread on the mailing list, my preference would be to remove nova.image altogether, and use Glance as the abstraction between image services, rather than having that abstraction inside Nova too. (I don't think that this was unanimously agreed.)

If we did this, then we'd remove image_service altogether, which is why nova.virt.xenapi is decoupled from that.

I don't know of any problems that would arise if image_service was out of sync with xenapi_image_service -- I'm expecting xenapi_image_service to take effect when using virt.xenapi, and image_service to take effect when using virt.libvirt.

[termie]

(by ttx) That's definitely another option. If we can make Glance the ultimate answer to all use cases, there is no need for a switch anymore :)