search

terminal42 / contao-changelanguage

ChangeLanguage is an extension for the Contao CMS which allows visitors to switch between different languages of your website.
43 stars 35 forks source link

Special icon for pages with no fallback language not shown #253

Closed minstyle closed 1 month ago

minstyle commented 1 month ago

Contao 5.3.11 PHP 8.3.9 terminal42/contao-changelanguage 3.7.4 Languages: DE + EN

If no fallback language is defined for a page, this is no longer indicated by a special icon in the Contao page structure. Therefore, it is currently not visible for which pages a fallback language is defined and for which not.

grafik

No fallback language defined:

grafik

fritzmg commented 1 month ago

The icon is only shown in the non-fallback trees. From your screenshots it is not clear whether that is the case for you or not (as English is typically the main/fallback language).

minstyle commented 1 month ago

German page tree is definded as fallback and the main language of the website:

grafik

The english page tree ist not defined as fallback:

grafik

fritzmg commented 1 month ago

You should set English as the fallback, not German btw. ;) (otherwise non-German speaking visitors will see the German website, instead of the English one).

Anyways, I can reproduce the issue in 3.7.4.

aschempp commented 1 month ago

~You should set English as the fallback, not German btw. ;) (otherwise non-German speaking visitors will see the German website, instead of the English one).~

@fritzmg that is totally unrelated to this issue and not necessary true for all websites. It really depends on your client and shouldn't be stated as a generic fact.

Seems like the issue does exist and https://github.com/terminal42/contao-changelanguage/pull/254 should fix it. Closing this for the pull request then.