search

terminal42 / contao-dcawizard

A Contao CMS widget to handle external table records in the edit mode of the parent record.
10 stars 10 forks source link

Contao 4.4 buttons in simple modal window are not active #19

Closed qzminski closed 7 years ago

qzminski commented 7 years ago

https://github.com/isotope/core/issues/1819

qzminski commented 7 years ago

@aschempp @Toflar the only reasonable solution I can think of is 6591953.

Toflar commented 7 years ago

Actually, this is caused by https://github.com/contao/core-bundle/blob/master/src/Resources/contao/templates/backend/be_main.html5#L95-L103 and I don't know if we should consider this a Contao bug. I mean, why should Contao decide to disable every button in every modal if there is nothing to pick. I'm sorry but there are many reasons to open something in a popup, why should Contao just disable the buttons. This is nonsense. This should only happen in picker mode. /cc @leofeyer

Toflar commented 7 years ago

Does https://github.com/contao/core-bundle/commit/6a7d052a4b08047e4d42cd9f084d27d195aea0b1 fix that?

leofeyer commented 7 years ago

It probably does not.

aschempp commented 7 years ago

Maybe if we would only match for act=select?

leofeyer commented 7 years ago

No, we will have to match the extras parameter of the picker. If it is not present, we must not mess with the apply button. 😄

Toflar commented 7 years ago

Is that true, @aschempp? If so, please include in your PR for the picker :)

aschempp commented 7 years ago

That is not true. The picker value will be there in the select-multiple as well. Having or not having a picker does not define if the buttons are available.

qzminski commented 7 years ago

Fixed in 0d564e45880934a96d1c3a3865c5320ddb0d3f77.