search

terminal42 / contao-easy_themes

Contao extension "easy_themes"
https://unmaintained.tech/
MIT License
13 stars 11 forks source link

Add icon in Contao 4.2 #20

Closed kozi closed 8 years ago

kozi commented 8 years ago

unbenannt

Toflar commented 8 years ago

Contao 4.2 is not supported yet.

kozi commented 8 years ago

OK, then i have tested it a little bit and found this little "bug" ;)

kozi commented 8 years ago

^4.0 includes 4.2.

https://semver.mwl.be/#?package=contao%2Fcore-bundle&version=%5E4.0&minimum-stability=stable

Is ~4.0.0 correct?

Toflar commented 8 years ago

The dependency should not allow 4.2 which it currently does. Couldn't know that there will be a new back end theme. But I actually do not care about that. Instead of publishing a bugfix that prevents you from installing it in 4.2 we might as well just add support for it.^^

stefansl commented 8 years ago

@kozi there are some more incompatibilities (rightclick, dom-inject, hover-mode) in easy_theme to the new layout. But for now I'm happy, that it's installable and basic working in backend module mode :)

rflx commented 8 years ago

+1, btw. thank you @Toflar for adding support on it soon. 👍

Toflar commented 8 years ago

Implemented in a4619e38a4be2e1d47002833f24715d1901951e5. Already published as 2.2.3. Enjoy!