search

terminal42 / contao-easy_themes

Contao extension "easy_themes"
https://unmaintained.tech/
MIT License
13 stars 11 forks source link

Some tweaks for PHP8 #51

Closed RoflCopter24 closed 2 years ago

RoflCopter24 commented 3 years ago

This PR adds a check inside the label handling in EasyThemes.php to prevent issue #50 as well as check in front of the $_GET access in config/config.php to prevent the "undefined array key" warning in PHP8

Enrica-r commented 3 years ago

Urgent: Without this changes, the debug mode stops with error.

Please change line 65 in config also. is_array check is not enough. This produces same error. Check with isset($GLOBALS[...]) instead of is_array(...).

@RoflCopter24 Could you add the change on line 65 of config? Who could merge this PR after the change?

Thank you to all Enrica

Toflar commented 3 years ago

Yeah, imho we can release a version which is PHP 8 compatible and only works for 4.9+. 4.4 is EOL in a month anyway and the combination of using Contao 4.4 but PHP 8 makes no sense whatsoever.