search

terminal42 / contao-leads

Leads extension for Contao Open Source CMS; Store and manage form data with ease!
GNU Lesser General Public License v3.0
36 stars 24 forks source link

Fix icon for backend menu #90

Closed rabauss closed 4 years ago

rabauss commented 4 years ago

Fix the css for the back end icon. I was not sure how it's correctly compiled via webpack - because I got a completly different output while running npm run prod

aschempp commented 4 years ago

Does this work in Contao prior to 4.9 as well? Because the navigation markup changed there

rabauss commented 4 years ago

I hope so - because it's already merged in the master branch ;-) see: https://github.com/terminal42/contao-leads/commit/94c36cbcd362ea7ff9512ff14e4c1b9369eacf8d This PR just "built" the assets - should have done already here: https://github.com/terminal42/contao-leads/commit/357010a1434220ed130af664465e45383ec7bd69

Unfortunately I have no contao 4.4 with develop version working at the moment...

rabauss commented 4 years ago

Quick-Test with contao 4.4: The current stable version 1.4.18 is working with c4.4 - at least the icon. After a short time I had to realize, that the develop branch is only supporting: "contao/core-bundle":"^4.6",

Maybe the workflow with webpack on develop-branch should be documented - because as I said the output is not the same as in src/Resources/public/!

aschempp commented 4 years ago

I've merged this for now. Be aware that the develop branch is nowhere useable or stable, so this might change at some point.