search

terminal42 / contao-mailusername

MIT License
7 stars 5 forks source link

Change "Username" in forms to "E-Mail" #10

Closed CodeAlDente closed 8 years ago

CodeAlDente commented 9 years ago

It could confuse people if the login form asks for an username when you actually need to enter your e-mail address. Therefore you should consider to change the label for this in the appropriate forms (login, password recover etc.) or within the DCA configuration file.

Of course, this is a very low priority request, but few minutes of your work would make the whole thing more user friendly.

aschempp commented 9 years ago

That should already be the case. Which version did you install?

CodeAlDente commented 9 years ago

Thanks for your reply.

I've seen the line in the default.php but it still doesn't work. I've checked it twice. I'm using the latest version 1.0.4.9006 along with the newest version of Contao.

Total-Reality commented 9 years ago

Hmm it is the same like here?! https://github.com/terminal42/contao-mailusername/issues/10

CodeAlDente commented 8 years ago

Are you guys with me? I still need to fix this. Any idea is appreciated.

Toflar commented 8 years ago

I can confirm that there's an issue. I tried to find out where it comes from for like 2 hours now but I just cannot find the problem. Probably I'll have some project some day where I need to figure it out but for now you just have to live with the issue or find the source of the problem yourself. I can't help you for now.

aschempp commented 8 years ago

Maybe we should revert https://github.com/terminal42/contao-mailusername/commit/395592478762986e4cadcdd891fdef56ab3233b6 to fix the problem? Apparently the link does not work as expected, because loading the language files of the second language will override both versions…

Toflar commented 8 years ago

Maybe. But funnily enough, my debugging session showed that MSC.emailAddress contains Username which would be the wrong way around?!

aschempp commented 8 years ago

I know, thats the problem. I guess that happens due to the "link" between the two labels. When the username variable is set again (due to loading a second language), it also overrides the email field.

Total-Reality commented 8 years ago

What can I do to solve this Newsletter Problem temporarily? Look at the 4th box in the right column please: https://www.fast-end-media.de/produkte/

Toflar commented 8 years ago

Find the issue and fix it? :D

Total-Reality commented 8 years ago

???? Can you answer here please? https://github.com/terminal42/contao-mailusername/issues/9

aschempp commented 8 years ago

Please read https://www.terminal42.ch/en/open-source.html

Total-Reality commented 8 years ago

What does that mean?

Total-Reality commented 8 years ago

I found the reason of this bug...

Please change system/modules/mailusername/languages/en

Before: $GLOBALS['TL_LANG']['MSC']['username'] = &$GLOBALS['TL_LANG']['MSC']['emailAddress'];

After: $GLOBALS['TL_LANG']['MSC']['username'] = $GLOBALS['TL_LANG']['MSC']['emailAddress'];

aschempp commented 8 years ago

Thanks for the input! I think this would only work for english though. Did you try other languages?

CodeAlDente commented 8 years ago

I've tried it in other languages, but it does only work if you change it for English. Maybe there is a problem with detecting / setting the language?

Total-Reality commented 8 years ago

Andreas: No my Website Language is "de" / German. Strange to say but the code change I posted above results in correctness in the german website/language.

aschempp commented 8 years ago

Should be fixed in 9398d005c21e4a9c4af57b81cf9a78a97ff3cc85

CodeAlDente commented 8 years ago

It is, thank you!

Total-Reality commented 8 years ago

Yeah, thank you very much :)