Make the mailusername case-insensitive

terminal42 / contao-mailusername

MIT License

7 stars 5 forks source link

Make the mailusername case-insensitive #13

Closed richardhj closed 5 years ago

richardhj commented 7 years ago

It is a well-discussed topic in the Contao community and I wonder how it didn't get onto GitHub. In all projects with mailusername users cope with problems according the case-sensitive email address. Some users lock out of their account. So I propose to treat the username as case insensitive by altering the sql definition. The modified sql definition will

treat the username (=email address) as case-insensitive and
allow up to 255 characters (this is the same limit used for the email field). I'm aware of the counter-argument of decreasing the all over security.

aschempp commented 7 years ago

Sounds reasonable to me. Other opinions @terminal42/pilots ?

Do we need the COLLATE setting? Because we don't really know the default collation, we just don't want it to be binary, right?

richardhj commented 7 years ago

Do we need the COLLATE setting? Because we don't really know the default collation, we just don't want it to be binary, right?

I cannot answer this.

richardhj commented 7 years ago

I just rethought the 255 char limit. When someone decides to uninstall mailusername he will probably get problems when all usernames get truncated to 64 chars, didn't he?

aschempp commented 7 years ago

yeah, but not increasing it would not really be a solution either, because they can enter longer emails than usernames can support…

richardhj commented 5 years ago

Do we need the COLLATE setting? Because we don't really know the default collation, we just don't want it to be binary, right?

@aschempp Your concern still present?

aschempp commented 5 years ago

Maybe it would rather be correct to *limit e-mail to 64 chars like the username is? By just setting maxlength?

richardhj commented 5 years ago

Will do.

aschempp commented 5 years ago

Do we want to change the database length? This could potentially result in data loss. My idea was to only limit the input length 😇

richardhj commented 5 years ago

This is what I did :) The length of the username is 64 as per Contao default. I added a soft limit for the email as well.

aschempp commented 5 years ago

why the $GLOBALS['TL_DCA']['tl_member']['fields']['username']['sql'] = "varchar(64) COLLATE utf8_general_ci NULL"; then?

richardhj commented 5 years ago

Emphasis on the "ci". We want the email to be case-insensitive.

aschempp commented 5 years ago

Ah, very well then 👍