Split session handling into separate class

terminal42 / contao-mp_forms

Real step separation in the form generator of the Contao Open Source CMS

25 stars 13 forks source link

Closed aschempp closed 2 years ago

aschempp commented 2 years ago

This splits the session handling from form field handling. In https://github.com/terminal42/contao-conditionalformfields/ I need to fetch the session data of previous steps. But using MPFormsFormManager results in an endless loop (see https://github.com/terminal42/contao-conditionalformfields/issues/60) because it initializes all fields and call the compileFormFields hook again.

This should be BC and can be released as 4.4.0 if you agree 🙃

zonky2 commented 2 years ago

ich teste..

aschempp commented 2 years ago

Would be nice to update the code to have all PHP 7.4+ features already, but I assume it's not a part of this PR.

Yeah I didn't want to do that because I guess it needs (yet another) rewrite at some point 😆