terminal42 / contao-node

Manage content centrally as nodes and reuse them everywhere.
MIT License
29 stars 8 forks source link

Fix for DBAL 3 (Contao 4.13) #32

Closed dennisbohn closed 2 years ago

dennisbohn commented 2 years ago

I am getting the following error, when I try to create a node in Contao 4.13.

image

Contao 4.13 switched to DBAL 3 and doesnt support the method fetchColumn and fetchAll anymore.

https://www.doctrine-project.org/2020/11/17/dbal-3.0.0.html

I changed fetchColumn to fetchOne and fetchAllAssociative which results in the same behaviour.

dennisbohn commented 2 years ago

The requirements of Contao 4.13 says "doctrine/dbal": "^3.2".

I added "doctrine/dbal": "^2.13 || ^3.0" to the composer.json.

dennisbohn commented 2 years ago

Now I just have to find out how to add the commit to the existing pull request. ;)

dennisbohn commented 2 years ago

I open a new pull request.

https://github.com/terminal42/contao-node/pull/33

fritzmg commented 2 years ago

The requirements of Contao 4.13 says "doctrine/dbal": "^3.2".

I added "doctrine/dbal": "^2.13 || ^3.0" to the composer.json.

Yes, sorry, that's what I meant actually :)

Now I just have to find out how to add the commit to the existing pull request. ;)

Just go to your fork and branch on Github and edit the file there for example.

dennisbohn commented 2 years ago

Thanks, the commits were in the fork but not in the pull request. Maybe an issue on github, because I hat some timeouts when I tried to commit the file and had to reload several times.