terminal42 / contao-notification_center

The most popular notification configuration extension for the Contao Open Source CMS!
63 stars 38 forks source link

Send error at log if recipient email empty #291

Closed zonky2 closed 9 months ago

zonky2 commented 1 year ago

Currently there is no info why an email is not sent because the recipient address field is empty - e.g. when it is filled by a simple token.

aschempp commented 9 months ago

Don't you already get the exception message a few lines below in your system log?

zonky2 commented 9 months ago

Don't you already get the exception message a few lines below in your system log?

No!

aschempp commented 9 months ago

I see that $objEmail->sendTo() returns false if the recipient list is empty. And none of the core "sender" places seem to handle that. I think we should rather log false the same as the exception. Should be fixed in fb63810b9c52eb9800dddea59be79901f57aad78, released as 1.7.3