search

terminal42 / contao-notification_center

The most popular notification configuration extension for the Contao Open Source CMS!
63 stars 38 forks source link

Should the sender name be mandatory? #313

Closed bennyborn closed 6 months ago

bennyborn commented 6 months ago

In NC 2.0 is there any reason why the sender email is now mandatory? I think there is potential room for error if the user is forced to make sure that the sender is the same as in the configured transport.

aschempp commented 6 months ago

I agree, I don't see a reason why it needs to be mandatory.

Toflar commented 6 months ago

Fixed in https://github.com/terminal42/contao-notification_center/commit/a7dcea84891bf159028eb540cdadf382074cf811.

fritzmg commented 6 months ago

I think there is potential room for error if the user is forced to make sure that the sender is the same as in the configured transport.

To be clear: a transport does not have a configured sender. You can override the sender for a transport - but this would always be forced, no matter what the notification would say.

In the past the default sender was the admin email from the root page or the system settings - which I hope is still the case in 2.0?

Toflar commented 6 months ago

It's not as far as I can tell. PR welcome :)