terminal42 / contao-notification_center

The most popular notification configuration extension for the Contao Open Source CMS!
63 stars 38 forks source link

Add support for friendly admin emails #336

Closed fritzmg closed 3 months ago

fritzmg commented 4 months ago

Currently the notification center will not send an email notification if you are using a friendly email for the administrator email address.

Similiar to https://github.com/terminal42/contao-notification_center/pull/298 this PR fixes that.

Notes:

Toflar commented 3 months ago

I wasn't sure whether translations are managed on Transifex or not. I have only adjusted the English translation.

They are not, see README.

  • @Toflar I changed the implementation of how the token values are added to the token collection. Is there a practical difference between
      $tokenCollection->addToken(new Token(…))

Yes, please change back. The reason for this is that you can replace/decorate the TokenDefnitionFactory and provide your own logic for the EmailTokenDefinition and do whatever you want in createToken() then.

fritzmg commented 3 months ago

I see :). Will adjust both.

fritzmg commented 3 months ago

Done 👍

Toflar commented 3 months ago

Perfect, thanks @fritzmg!