terminal42 / contao-notification_center

The most popular notification configuration extension for the Contao Open Source CMS!
63 stars 38 forks source link

Log unsuccessful deliveries to the system log #337

Closed fritzmg closed 3 months ago

fritzmg commented 3 months ago

This implements #335

image

fritzmg commented 3 months ago

Hm, the dependency checker complains about

Found shadow dependencies!
(those are used, but not listed as dependency in composer.json)

  • psr/log
      e.g. Psr\Log\LoggerInterface in src\EventListener\LogUnsuccessfulDeliveries.php:14

However this is technically not a hard dependency and thus does not necessarily need to be added as a requirement to the composer.json of this package. wdyt?

Toflar commented 3 months ago

However this is technically not a hard dependency and thus does not necessarily need to be added as a requirement to the composer.json of this package. wdyt?

I think this specific error we can ignore by adding a comment that logging is optional in https://github.com/terminal42/contao-notification_center/blob/main/depcheck.php

Toflar commented 3 months ago

PR looks correct otherwise, I guess you also tested it? :)

fritzmg commented 3 months ago

PR looks correct otherwise, I guess you also tested it? :)

Yes, screenshots from above are from the test 👍

Toflar commented 3 months ago

Thanks @fritzmg