Closed fritzmg closed 3 months ago
Hm, the dependency checker complains about
Found shadow dependencies!
(those are used, but not listed as dependency in composer.json)
• psr/log
e.g. Psr\Log\LoggerInterface in src\EventListener\LogUnsuccessfulDeliveries.php:14
However this is technically not a hard dependency and thus does not necessarily need to be added as a requirement to the composer.json
of this package. wdyt?
However this is technically not a hard dependency and thus does not necessarily need to be added as a requirement to the
composer.json
of this package. wdyt?
I think this specific error we can ignore by adding a comment that logging is optional in https://github.com/terminal42/contao-notification_center/blob/main/depcheck.php
PR looks correct otherwise, I guess you also tested it? :)
PR looks correct otherwise, I guess you also tested it? :)
Yes, screenshots from above are from the test 👍
Thanks @fritzmg
This implements #335