search

terminal42 / contao-notification_center

The most popular notification configuration extension for the Contao Open Source CMS!
63 stars 38 forks source link

Extracted the FileUploadNormalizer service #346

Closed Toflar closed 2 months ago

Toflar commented 2 months ago

I don't want to introduce BC here because that service is very unlikely to have been used by third party bundles (and even if they did, that was never intended). I've moved it to haste in https://github.com/codefog/contao-haste/pull/221 where it's better suited and also used by mp_forms now.

If you stumble over this PR and you actually did use it (again, you were not supposed to and I won't provide a BC layer), you can fix your code very easily: require ^5.2 of codefog/contao-haste and use Codefog\HasteBundle\FileUploadNormalizer instead of Terminal42\NotificationCenterBundle\Util\FileUploadNormalizer.

zoglo commented 2 months ago

@Toflar codefog/contao-haste needs at least symfony/mime: ^6.0 which doesn't work with Contao 4.13 since it runs on symfony 5 (and uses symfony/mine ^5.4)

Meaning: You can not install NC 2.0.10 and it's Contao 5 only