terminal42 / contao-pageimage

MIT License
12 stars 14 forks source link

Make the helper service public #45

Closed qzminski closed 3 years ago

qzminski commented 3 years ago

So it can be accessed e.g. via System::getContainer()->get(\Terminal42\PageimageBundle\PageimageHelper::class).

aschempp commented 3 years ago

As discussed, you should probably create an alias of the service and make it public in your bundle/module. That way you don't depend on this, and if you ever rewrite legacy code to dependency injection, this bundle won't have a left-over public service noone is using 😊