terminal42 / contao-pageimage

MIT License
12 stars 13 forks source link

Fix palette layout #55

Closed fritzmg closed 12 months ago

fritzmg commented 1 year ago

Before:

image

After:

image

aschempp commented 1 year ago

feels like this is actually intended 😅 but maybe we should place the two input fields next to each other and the checkboxes after them?

fritzmg commented 1 year ago

hm, idk, you'll need to decide that ;). If this was really intended then you might as well leave it as is - though I don't think Contao's layout actually intended this to be used this way.

aschempp commented 1 year ago

Yes it is, thats exactly what m12 is for? If you have only one checkbox next to a field, you need m12. If you want two, don't use m12. Otherwise checkboxes could always have m12 😅

But maybe @leo @Toflar can shed their opinion?

fritzmg commented 1 year ago

The Contao Core uses m12 whenever a checkbox is to the left or right of a regular text or select input field. If two checkboxes are besides each other, you do not need to use m12.

Toflar commented 1 year ago

I have no clue, I use m12 when it looks shit without m12 🤣 But if what you're saying is true, it could probably all be automated.

fritzmg commented 1 year ago

But if what you're saying is true, it could probably all be automated.

Not with the current back end CSS I think. See also https://github.com/contao/contao/pull/2053

aschempp commented 12 months ago

Closing this as the current view is intended.