terminal42 / contao-pageimage

MIT License
12 stars 14 forks source link

levelOffset + inheritPageImage #58

Open asaage opened 3 months ago

asaage commented 3 months ago

The combination of levelOffset + inheritPageImage does not work like expected. If the module is configured to display the second pageimage (Start level = 1) and "use parent image" is checked there is currently no output if the page has only one image set. I think it would be logical to look for a second image in parent pages then. What do you think - feasable?

aschempp commented 3 months ago

that is not how this is currently designed 🤔. Either you set all images in a page, or none. For example, I used multiple images several times to generate a slider. I wouldn't want to get a slider of the parent images if my current page only has one image.

asaage commented 3 months ago

You would uncheck "use parent image" in this case wouldnt' you? Or do you have one FEmodule that automatically decides whether to do a slider or a single-image?

My usecase has two FEmodules which display images in different places 🤷‍♂️. Can't wrap my head around if its possible to make a configuration that suits both needs at the moment. I guess i'm just going to assign all images to all my pages then. Feel free to close this!

aschempp commented 2 months ago

Or do you have one FEmodule that automatically decides whether to do a slider or a single-image?

Yes I have (a template actually).

My usecase has two FEmodules which display images in different places 🤷‍♂️. Can't wrap my head around if its possible to make a configuration that suits both needs at the moment. I guess i'm just going to assign all images to all my pages then. Feel free to close this!

Hmm, that totally makes sense. Maybe we should inherit if you have set a levelOffset bigger than 1 (and the inherit checkbox). For my case, I never have an offset (I have multiple images though).

asaage commented 2 months ago

Maybe we should inherit if you have set a levelOffset bigger than 1 (and the inherit checkbox).

probably maybe dontknow...🙈