2.0 should not be labeled 2.11 compatible in ER2

terminal42 / contao-pageimage

MIT License

12 stars 14 forks source link

2.0 should not be labeled 2.11 compatible in ER2 #9

Closed fjacobi closed 10 years ago

fjacobi commented 10 years ago

Customer crashed his installation with that update, I guess this is a mistake?

aschempp commented 10 years ago

Well it looks like it should be compatible. So without more info I can't do anything...

fjacobi commented 10 years ago

Well, I got the error log and forgot to post it here.

Has PHP 5.3 dependency due to namespace usage.

So I'd say this can be closed.

aschempp commented 10 years ago

I can't see any namespace usage in current master branch...

fjacobi commented 10 years ago

https://github.com/terminal42/contao-pageimage/blob/master/ModulePageImage.php#L65

aschempp commented 10 years ago

It will work if you do not use PHP 5.2. I agree this is not fully compatible with Contao 2.x, but marking it as incompatible does not fix the issue either. As we will release version 3.0 soon, this will be obsolete.