search

terminal42 / deployer-recipes

Tools and recipes for deployer.org
MIT License
10 stars 3 forks source link

Do not exclude favicon.ico #7

Closed richardhj closed 4 years ago

richardhj commented 4 years ago

Removing this, because the install-web-dir command does not add a favicon.ico anymore, and, not having a favicon.ico blows up my error log ("No route found for "GET /favicon.ico"")

Toflar commented 4 years ago

In 4.9 there will be a route for Contao ;)

richardhj commented 4 years ago

In 4.9 there will be a route for Contao ;)

I have one favicon route in my app as well. What happens when two routes have the same target?

Toflar commented 4 years ago

First one wins.

aschempp commented 4 years ago

I have one favicon route in my app as well. What happens when two routes have the same target?

First one in this case actually means last one. As everywhere in Contao, a later bundle will overwrite a previous one. Your app "bundle" is always last, so your app route will win.