search

terminus-plugin-project / terminus-pancakes-plugin

Terminus Plugin to open Pantheon Site Databases in your Favorite SQL Client
MIT License
26 stars 20 forks source link

Add MySQL App #17

Closed bensheldon closed 7 years ago

bensheldon commented 7 years ago

This PR proposes a new --app for invoking the mysql CLI.

Example: terminus pc site.env --app mysql.

I'm not enthusiastic about using proc_open, but I wasn't sure what a good alternative would be for having Terminus handoff control to another cli process.

Thank you in advance for feedback!

derimagia commented 7 years ago

Looks good, this is probably useful to some people who can't use drush. For validate can you use which instead? (I just fixed it on master today so you prob should merge master back in, https://github.com/terminus-plugin-project/terminus-pancakes/pull/18/commits/e40aeaabefddbaaaf93a9343f9252c268af2e225)

Drush uses proc_open as well, it prob is the best way to do it.

bensheldon commented 7 years ago

@derimagia I updated the PR using $this->which (hope I did it right!) and rebased off master.

I appreciate the feedback (and the plugin)!

derimagia commented 7 years ago

Can you put the commit on the your PR branch?

bensheldon commented 7 years ago

I fixedup the changes back into the original commit and pushed just that back into the branch.

derimagia commented 7 years ago

My bad, I see you replaced the commit. Looks good to me, thanks!

bensheldon commented 7 years ago

Thank you!